Hi there - and welcome to the country!
Edinburgh can be an expensive place to live, but on the upside it is a largely nice-looking, clean and tidy town. Edinburgh folks IMHO aren't necessarily always the cheeriest people in Scotland... but then there are always exceptions to that rule! (e.g. the guys on this forum ). In any case, it's undoubtedly a very interesting and cosmopolitan city with plenty to see and do all year around - I'm sure you'll enjoy it. Some of the Edinburgh locals (e.g. Midnight21) will be able to advise on accommodation, etc.
Scotland's generally a very good place to be a Scooby/driving enthusiast, although the big downside is the high fuel cost (currently around $6.70 for a US gallon of super unleaded!). However, you don't have to go far from Edinburgh to find some great twisty roads (the Borders region, in particular). The Highlands also has plenty of great driving roads to offer if you don't mind a bit of a trek getting there.
All the best!